
Design comparison
Community feedback
- @edu-abualasalPosted 3 months ago
Cool, almost pixel perfect! The text line-height need to be set and it will be 100%. Check the design system for the correct line height values.
You can drop media queries and make the card responsive with smooth scaling using min-width, max-width and flex grow, shrink and basis.
0P@LoicLamaillePosted 3 months ago@edu-abualasal Thanks for your answer ! Do you have some examples to drop media queries ? I am doing those challenges to improve my design skills. Thanks
0@edu-abualasalPosted 3 months ago@LoicLamaille Sure thing, checkout the solution I've submitted for this challenge, repo is here https://github.com/edu-abualasal/blog-preview-card Let me know if you have any questions, cheers.
0 - @saraypadillaPosted 3 months ago
Tu código tiene una estructura clara y bien organizada, lo cual es genial. Podrías considerar mejorar la accesibilidad agregando atributos como alt más descriptivos en las imágenes (por ejemplo, en illustration-article y image-avatar) para que los usuarios con lectores de pantalla puedan entender mejor el contenido visual.¡Buen trabajo!.
0P@LoicLamaillePosted 3 months ago@saraypadilla Thanks google translate haha. I am doing this to improve my design skills so didn't really pay attention to this. But this is an important point, thank you
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord