Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Blog Card

P

@Hekimianz

Desktop design screenshot for the Blog preview card coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

P

@Islandstone89

Posted

HTML:

  • I would wrap the card in a <div class="card">, as the <main> would likely have more content than just a card.

  • It is common to use classes instead of IDs, so replace those.

  • I would wrap the date in a <time> element:<p>Published <time datetime="2023-12-21">21 Dec 2023</time></p>.

  • "Author" is a bit vague for the profile image alt text - I would change it to "Headshot of Gary Hooper".

CSS:

  • Including a CSS Reset at the top is good practice.

  • I like to add 1rem of padding on the body, to ensure the card doesn't touch the edges on small screens.

  • Except for the profile image, remove all widths and heights in px.

  • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • letter-spacing must also never be in px. You can use em, where 1em equals the font size of the element.

  • On the top image, add display: block and max-width: 100% - the max-width prevents the image from overflowing if its intrinsic size is larger than its container.

  • Remove align-self: center, it is not needed.

Marked as helpful

1

P

@Hekimianz

Posted

Thanks for the feedback! Very helpfull 😁@Islandstone89

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord