Design comparison
Solution retrospective
It was fun designing the card.
What challenges did you encounter, and how did you overcome them?Aligning small image with a text in same line was little bit tricky, eventually after searching a bit I realized I needed to use vertical-align property.
What specific areas of your project would you like help with?Guidance in Responsiveness
Community feedback
- @danielmrz-devPosted 7 months ago
Hey @Ashish-619!
Your solution is really impressive!
I've got a couple of ideas (about how to use HTML better) that could make it even stronger:
š First: Think about using
<main>
to wrap your main content instead of<div>
.Imagine
<div>
and<span>
in HTML as basic containers. They're good for holding stuff, but they don't tell us much about what's inside or its purpose on the webpage.š Second: Don't skip heading levels ā start with
<h1>
, then use<h2>
, and so on.It's more than just text size ā it's about structuring your content effectively:
- The
<h1>
to<h6>
tags are used to define HTML headings. <h1>
is for the most important heading.<h6>
is for the least important heading.- Stick to just one
<h1>
per page ā it should be the main title for the whole page.
These tweaks might not change how your page looks, but they'll make your HTML code clearer and help with SEO and accessibility.
Hope that's helpful!
Keep up the great work!
Marked as helpful1@Ashish-619Posted 7 months ago@danielmrz-dev Thank you, Daniel, I really appreciate your help!
0 - The
- @Grego14Posted 7 months ago
Hello! I have been reading your code and here are some recommendations:
Do not use 30vw to set the width to the .card element since on smaller screens it causes overflows. You can use something like this: max-width: 450px;
Don't skip the headings, you have a <h3> first and then a <h2> in your markup. <h1> should come first.
For the name of the person Ashish Vaidya you don't need to use a heading, you can use a <span> element.
I hope this helps!
Marked as helpful1@Ashish-619Posted 7 months ago@Grego14 Thank you for your feedback, but I am curious to know what difference it will make if I use <span> for the name instead of heading
0@Grego14Posted 7 months ago@Ashish-619 It's because headings are mostly used for titles or subtitles on a website, but for that type of small text I like to use spans š.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord