@danielmrz-dev
Posted
Hello @Naveen-CB!
Your solution looks excellent!
I have a couple of suggestions:
- Use
mainto wrap the main content instead ofmainandarticle.
📌 The tag article would make more sense if the card was part of a bigger website (in certainly would in real world), but here it is all we have on the screen.
- Also, don't skip heading levels - start with
<h1>, then use<h2>, and so on.. Unlike what most people think, it's not just about the size and weight of the text.
📌 The <h1> to <h6> tags are used to define HTML headings.
📌 <h1> defines the most important heading.
📌 <h6> defines the least important heading.
📌 Only use one <h1> per page - this should represent the main heading/title for the whole page.
Those tag changes don't impact your project visually and make your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
Marked as helpful
@Naveen-CB
Posted
@danielmrz-dev Thank you for a helpful feedback, but I also wonder how to get pixelperfection can you have any suggestion or video/article to explain that?
@danielmrz-dev
Posted
@Naveen-CB
The only way to get pixel perfection is having the design figma files that explicits all the exact measures. Other than that, we have to do it by eye 😅
@Naveen-CB
Posted
@danielmrz-dev Oh 😂 let's take ruller to measure it on the screen.
@danielmrz-dev
Posted
@Naveen-CB
I swear I already did that a few times 🤣🤣🤣
@Naveen-CB
Posted
@danielmrz-dev same here🤣🤣
