@oaved
Posted
I think you have good code hygiene in your HTML and CSS and I think the card looks nice. I'm not by any means a seasoned programmer but I some tips for you!
HTML: You could try to use more sematic tags instead of divs. Maybe try tags like figure, article and figcaption in this project. Also, think about how you use your h1-h6 tags. In a card component like this, which is one coherent component, all h-tags should come in order. The h-tags should also be picked based on their semantic meaning, not by their size. I kinda looks like you have choosen h-tags here based on their size. If you haven't, you can disregard this last tip.
CSS: Try using more general names for your custom properties. Using the property "yellow" can get confusing if this card later on updates to be blue. You could therefore try naming your custom properties like "--clr-primary" and "--clr-accent" or something along those line.
Overall great design!
