Hey, it looks good I have a few suggestions for you to help.
When you download the starter file and the figma file, you can look for the style guide and open it up in your VSC IDE. This will give you the coloring in hsl for your background, containers, your text and font sizes.
you can add this i your pseudo classes.
When you make updates on your code, It's not going to upload automatically on your Git file so we have to do this manually.
- git status 2 git add . (Adds all new updated files)
- git commit -m "Description of your change"
- git push origin main
This will upload the updated files to your git
If you want to add a <footer> always add it outside of the <main>.
We want to use rem instead of px. px are absolute units/sizes and are less responsive. There is a simple way to calculate your rem. pixels/16px 16 pixels = 1 rem
You can implement these and feel free to ask more questions.
Happy coding!
Marked as helpful
@gilotin
Posted
@Nico243 I'll change pixels to rem , tomorrow, thanks for the suggestion.
When you make updates on your code, It's not going to upload automatically on your Git file so we have to do this manually.
git status 2 git add . (Adds all new updated files) git commit -m "Description of your change"
git push origin main This will upload the updated files to your git
Can you explain what you mean, I don't see any problem with the code, or you are watching the history of code updates ?
For pushing new updates I'm trying to use :
ADD:, UPDATE:, CHANGE:, DELETE: etc. before the massage to clarify what I'm doing. I'm pushing via VS code git extension.
Is there any problem with that ?
For the footer I'll check , in older challenges , because I don't have one here, but thanks for the suggestions, really appreciate them!
