Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Better Looking QR code solution

@jamesweiss213

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I used one of the other solutions to help me figure out how to better round out the edges via flexbox, better padding after-the-fact that the container holding the image should've started as the same width by width:inherity, and I centered the content using justify-content:center on the box holding all the other content. Should be better now. Sizing wize, it was hard to gauge, though, so I sort of eyeballed it.

Community feedback

@0xabdulkhaliq

Posted

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

HEADINGS ⚠️:

  • This solution had generated accessibility error report due to lack of level-one heading <h1>
  • Every site must want at least one h1 element identifying and describing the main content of the page.
  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

0

@jamesweiss213

Posted

@0xAbdulKhalid I don't like adding <h1> headers. I don't know what the presets are for it, and it constantly gets in the way of my code. <p> tags are usually less disruptive which is why I sort of refuse to use header tags until I get a better grasp of how to get rid of the presets that would otherwise ruin the code.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord