Bento-Grid

Community feedback

• 

  Fernando A. Malfavón•370

  @WlfernandoPosted about 1 month ago

  Great job! There's one thing that picked my attention: Why do you declare that many rows?

  You could declared grid-template-rows: 250px 75px 175px 250px; adding to your declare on

  grid-template-areas:
     "box7 box1 box1 box4"
     "box7 box2 box3 box4"
     "box8 box2 box3 box4"
     "box8 box6 box5 box5";
  

  or declare:

  grid-template:
    "box7 box1 box1 box4" 250px
    "box7 box2 box3 box4" 75px
    "box8 box2 box3 box4" 175px
    "box8 box6 box5 box5" 250px
  / 1fr 1fr 1fr 1fr;
  

  (Notice that I didn't use the function repeat here because is invalid with this short-hand).

  Also, your declaration with grid-auto-rows: repeat(10, 60px) is invalid, be careful with that. You can know it by opening the devTools of your navigator.

  0