Design comparison
Solution retrospective
I finished the project pretty quickly and although the hover effect for the image was a bit tricky I wasn't stuck for too long
What challenges did you encounter, and how did you overcome them?I didn't have too many challenges except for getting used to write the css in a different way than usual :)
What specific areas of your project would you like help with?I'd like to know if I implemented the BEM methodology right or if there is some aspect that is still not quite what it should be. Since it is my first time using BEM any feedback about it would be helpful
Community feedback
- @Yejin-HanPosted 4 months ago
Hello!
First of all, I'm proud of you that you've tried hard to finish it! By using BEM, I can understand your code instantly. I think you've done well!
But one thing, I learned that using 100vh in body or some area to make it full in screen is not suitable for mobile devices because of address bar, etc... How about considering it?
Here are the links that you can refer to: https://medium.com/@alekswebnet/fix-mobile-100vh-bug-in-one-line-of-css-dynamic-viewport-units-in-action-102231e2ed56 https://dev.to/nirazanbasnet/dont-use-100vh-for-mobile-responsive-3o97
Thank you.
Marked as helpful0@Annalisa11Posted 4 months ago@Yejin-Han didn't know about that, thanks! Will look into it
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord