Design comparison
SolutionDesign
Solution retrospective
Just starting out, any feedback welcome! :)
Community feedback
- @BernardusPHPosted over 1 year ago
Hey JOSEPH CASTELLI
Great project. I would like to add a suggestion
Please don't use a div as a landmark without reason(like a framework). What I mean is, the DIRECT children of the body. There are a few landmarks like
- nav
- main
- footer
- aside etc.
For your project I would just replace the direct children of the body into main and footer respectfully. The reason for this is for the developers so we don't get easily lost in the code and also screen readers use the landmarks. The footer is for the link that you can place at the bottom
Hope this helped
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord