Skip to content
Submitted over 1 year ago

Beginner product preview card component : Need help please

Delgorithm•120
@Delgorithm
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Product preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hello everyone!

It is my first frontend mentor's project. I've decided to try 4 projets like this one per week. However, since I'm a beginner, I found it difficult to achieve it. As you can see, there's a lot a issues in it. As so, don't hesitate to tell me and advice me about those things.

My only purpose is to develop. So I have to create and learn, as the same time, from you and from me.

Thank you in advance for your time.

Also, I've tried to use Vercel and gitHub to host my code. But, for vercel I'm actually at 23min "assigning domains" and with gitHub, I've looked on youtube and your guide, it seems that I can't find why it doesn't work...

Take care and have a good day!

Community feedback

  • visualdennis•8,375
    @visualdennissPosted over 1 year ago

    I'd suggest instead of adding padding-top: 100 to the container, just add: display: grid; place-items: center; to the body, since it is 100svh, it will center the container on the page.

    Image seems to be missing and not uploaded to github.

    For deploy, i use Netlify, which i can also recommend, all you need to do is drag and drop the file (folder that contains index.html and css) on it and it gets automatically deployed. You might wanna try.

    Hope you find this feedback helpful!

    Marked as helpful
    1
  • Abdul Khaliq 🚀•72,560
    @0xabdulkhaliqPosted over 1 year ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    HTML 🏷️:

    • This solution generates accessibility error reports, All page content should be contained by landmarks is due to non-semantic markup, which lack landmark for a webpage
    • So fix it by replacing the <div class="container"> element with the semantic element <main> along with <div class="attribution"> into a <footer> in your index.html file to improve accessibility and organization of your page.
    • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>
    • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

    FEEDBACK :

    • The image file you provided is seems to be missing in your github repo
    • <img src="/images/image-product-desktop.jpg" alt="Gabrielle Essence Eau de Parfum">
    • So kindly upload the image asset to your repo and then try again.

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    Marked as helpful
    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord