@MelvinAguilar
Posted
Hi @nenadmne π, good job on completing this challenge! π
Here are some suggestions you might consider:
Try to use semantic tags in your code. It should have the main tag that groups all of the product elements.
- For specificity reasons you should work better with
classes
since they are reusable, and you can leave theID
when you work with Javascript. - Add an h1 tag to your solution. The
<h1>
element is the main heading on a web page. There should only be one<h1>
tag per page, and always avoid skipping heading levels; Always start from<h1>
, followed by<h2>
, and so on up to <h6> (<h1>,<h2>,...,<h6>). The HTML Section Heading elements (Reference)
Solution:
<h1 class="heading">Gabrielle Essence Eau De Parfum</h1>
- You can use a <picture> tag when you need to change an image in different viewports. Using this tag will prevent the browser from loading both images, saving bandwidth and preventing you from utilizing a media query to modify the image.
Example:
<picture>
<source media="(max-width: 576px)" srcset="./images/image-product-mobile.jpg">
<img src="./images/image-product-desktop.jpg" alt="your_alt_text">
</picture>
- The cart icon is for decoration purposes only, so it can be hidden from screen-readers by adding
aria-hidden="true"
and leaving its alt attribute empty:
<img class="cart" src="./images/icon-cart.svg" alt aria-hidden="true">
- You could use the <del> tag to display the old price:
<del class="small-price">
<span class="sr-only">Old price: </span>$169.99
</del>
Note that I added the <span> with the sr-only
class to the del
element, this will provide more information about what your old price is about.
The sr-only
class is a class that you can add to hide content visually but is only visible to screen-readers.
I hope those tips will help you.
Good job, and happy coding!
Marked as helpful
@nenadmne
Posted
@MelvinAguilar noted. Thanks for review!