Beautiful Card Made With CSS

Community feedback

• 

  Chris Jones•20

  @leekPosted over 2 years ago

  • Avoid using id attributes. Use class for styling when possible.
  • You use a mix of Capitalized and camelCase throughout your code; try to stick to one format.
  • <br> tag after #paymentBtn should be removed and positioning should be done with CSS.
  • "Cancel Order" button's background hangs over the drop shadow of the button above it.
  • Avoid specifying width/height/margin in px unless absolutely necessary.

  A few small issues but otherwise it looks good. A few minor differences from the original design.

  Marked as helpful

  0

  ---

  

  Abdur Raheem•130

  @AbdurRaheemCPosted over 2 years ago

  @leek Thank you for the help !!!!

  0
• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Abdur, great work on this challenge! 😉

  Here are a few tips for improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • add descriptive text in the alt attribute of the images
  • not use <br> to separate element because it's for break line of text. Use css display property
  • you can fix the top image in the background just put more specific background properties like this:

  background: url("../img/pattern-background-desktop.svg") no-repeat top center;
  background-size: contain;
  background-color: #e0e8ff;
  

  • instead of using px use relative units of measurement like rem -> read here

  Overall you did well 😁 Hope this help!

  0

  ---

  

  Abdur Raheem•130

  @AbdurRaheemCPosted over 2 years ago

  @denielden I will use in future projects : )

  1