Basics HTML and CSS. CSS files are separated.

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted over 3 years ago

  Nice work on this challenge, Michael! I'd recommend sticking to a single CSS file. As you start building larger projects, you'll likely want to look into using Sass. Among other things, it allows you to break your styles up into separate "partial" files. These partials can then be compiled into a single CSS file, which helps you organise your code better.

  I'd recommend sticking with CSS for the time being and use a single file. Once you get to larger projects, take a look at Sass.

  Just a quick note on your HTML. You've currently got multiple h1 elements. Although this is valid HTML, it's generally still considered a bad practice, as it can cause accessibility issues with the content hierarchy. Instead, I'd recommend sticking to a single h1. For this challenge, it doesn't really have a h1 in the design, so you could create a h1 that would be hidden and only accessible to screen reader users. That would mean the headings for each card would be perfect as h2 headings.

  Keep up the great work!

  0

  ---

  

  Michael RANDRIAJAOSON•20

  @andolalainaPosted over 3 years ago

  @mattstuddert Thank you for your advices. I will take them into consideration for future projects :)

  0