Design comparison
SolutionDesign
Community feedback
- @moadavouPosted 7 months ago
Great work on completing this project!
- In your HTML you wrap the
h1
andh2
tags in adiv
. This is unnecessary since you can just put theid
on theh1
orh2
tag like this:<h2 id="location">London, United Kingdom</h2>
- Class names have a higher specificity than id´s. I'm not an expert on this, but I believe that class names can be easier to use for that reason.
- Don't use
px
forfont-size
. This unit is not responsive and won't change depending on the user's settings.
- You can't set
font-weight
in pixels. Just use a number. For example:font-weight:700;
0 - In your HTML you wrap the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord