Skip to content
Submitted almost 3 years ago

Basic React composition, semantic html and BEM css naming conventions

Indika Kolamba Tantregeβ€’60
@iamindika
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Please let me know if I could have structured my html more semantically or named my css using BEM any better. If you notice any improvements I could make on my use of react I would greatly appreciate that feedback as well! Thanks!!

Community feedback

  • Anosha Ahmedβ€’9,300
    @anoshaahmedPosted almost 3 years ago

    Hey good job on this challenge! Wrap everything in your body in <main> ... OR use semantic tags! .... you can also give role="" to the direct children of your <body> but that's a little frowned upon... Read more here

    Hope this helps :)

    Marked as helpful
    1
    Indika Kolamba Tantregeβ€’60
    @iamindikaPosted almost 3 years ago

    @anoshaahmed I'll definitely look at using more of those semantic tags. Ty Anosha!

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord