Basic qr component utilizing only HTML and basic CSS

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Luis, great work on this challenge! 😉

  Here are a few tips for improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • add descriptive text in the alt attribute of the images
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the comments
  • remove margin-top, left and transform properties from container class
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container

  Overall you did well 😁 Hope this help!

  Marked as helpful

  1
• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hi, Luis! 👋

  Congratulations on completing your first Frontend Mentor challenge! 🎉 It's great that you are able to finish this challenge without any media queries! Well done! 👏

  I would recommend adding an alternative text for the QR code. It's the main content of the page and it should be visible for all users (including the users of assistive technology). So, the alternative text like "QR code for Frontend Mentor site" would be great.

  Keep up the great work! 👍

  Marked as helpful

  1