Basic notification website using HTML, CSS and JavaScript

Community feedback

• 

  Bernardo Poggioni•5,280

  @R3ygoskiPosted 6 months ago

  Hello @JamesWallison, the project turned out really well, congratulations, and thank you for the compliment.

  Marked as helpful

  1
• 

  Abdul Khaliq 🚀•72,580

  @0xabdulkhaliqPosted 6 months ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have a suggestion regarding your code that I believe will be of great interest to you.

  ---

  PREVENT LAYOUT SHIFTS 📉:

  • Your solution needs to be improved to prevent Cumulative Layout Shift (CLS) which results a visually unstable or janky website, particularly on mobile devices.

  ---

  • This can happen because of leaving the Image and/or video elements without adding explicit width and height attributes.

  ---

  • The multimedia elements like img which aren't explicitly declared with height and width attributes are usually re-sized using CSS (either on the image itself or the parent container). When this happens, the browser can only determine their dimensions and allocate space for them once it starts downloading the 'unsized images' and/or videos.

  ---

  • You may notice that when the browser fetches these images, your page content is constantly being pushed down or moved around from its original position (i.e., layout shifts) as the browser resizes the images and positions them on your page.

  ---

  • Currently the img element have no explicit width and height to prevent CLS,

  <img src="assets/avatar-mark-webber.webp" alt="Mark Webber">
  

  • Here's an example which could help you to prevent CLS,

  <img src="assets/avatar-mark-webber.webp" width="90" height="90" alt="Mark Webber">
  

  • The height and width needs to have the actual measurements of that corresponding image.

  ---

  • I would like to recommend the article Use explicit width and height on image elements from GTMetrix to learn more about Layout Shifts and why's it needs to be prevented.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1