BASIC HTML using BEM

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted over 4 years ago

  Hey Vitor, nice work on this challenge! You don't need to calculate the heights yourself, you just need to remove the set heights that you've added.

  For example, you've got height: 630px; on the .content class. You've also got height: auto; and max-height: 731px; on the html and body. Remove those and you'll see the height of the content grows and the curved pattern in the bottom left sticks to the bottom on mobile.

  I'd also recommend removing the max-width: 375px; from the html and body as it's restricting the width of the content for mobile devices. I normally prefer to have a .container class that is fluid all the way up to a specified pixel value.

  For example:

  .container {
    margin: 0 auto; /* centers content */
    width: 95%; /* fluid container for smaller devices */
    max-width: 1240px; /* controls max width of content for larger screens  */
  }
  

  This container can then be wrapped around content to control its width and make sure it's displayed correctly.

  I hope this helps. Keep up the great work! 👍

  1

  ---

  

  Vitor Marçal•95

  @vitormarcalPosted over 4 years ago

  @mattstuddert thanks for your feedback. I corrected and in the next challenge I will think in these terms too :)

  1