Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Basic HTML mark-ups, CSS flexbox and media-queries

Ridwan Hasanā€¢ 400

@Ridwan10000

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

I am proud of learning and using the media-queries. I will have a much strong hold on this topic. In future I will try to make fully responsive and accessible projects

What challenges did you encounter, and how did you overcome them?

I encountered problems regarding make this project responsive and good looking. I took help from chatGPT and learned about media-queries. Then added some break-points for different screen sizes and it showed up as somewhat responsive

What specific areas of your project would you like help with?

Give me tips about making pages responsive. Also, please answer my below questions-

  1. Should I always take mobile-first approach.
  2. What units in which context should I use to make my pages more responsive
  3. I used rem and em units only while learning. I know what they mean. But what are their use-cases and How can I have great skill regarding in their usage?

Community feedback

T
Chamuā€¢ 13,110

@ChamuMutezva

Posted

Hi Ridwan10000

Having gone through your project, here is my observation

HTML

  • find out more about landmark elements, which are very important in the structural organisation of your site. For this challenge , I would include the main element as it identifies the primary content of the webpage.
  • the alt value of an image element should exclude some words such as image, picture, logo etc as these are automatically implied and will cause a repetition of words when using a screen reader

CSS

  • you will need to reset your styles using a modern reset stylesheet
  • this challenge does not need a lot of media queries , infact you can do it without any media queries. Instead of the explicit width on the container width: 350px; , use max-width - it allows your component to scale . Also for sizes , use rems in most cases instead of px

Marked as helpful

1

Ridwan Hasanā€¢ 400

@Ridwan10000

Posted

Thanks for the suggestions @ChamuMutezva

0
Daniel šŸ›øā€¢ 44,230

@danielmrz-dev

Posted

Hello there!

Congrats on completing the challenge! āœ…

Your project is looking fantastic!

I'd like to suggest a way to make it even better:

  • Using margin and/or padding isn't always the most effective method for centering an element.

Here's a highly efficient approach to position an element at the center of the page both vertically and horizontally:

šŸ“Œ Apply this CSS to the body (avoid using position or margins in order to work correctly):

body {
    min-height: 100vh;
    display: flex; 
    justify-content: center;
    align-items: center;
}

I hope you find this helpful!

Keep up the excellent work!

Marked as helpful

1

Ridwan Hasanā€¢ 400

@Ridwan10000

Posted

@danielmrz-dev Many many thanks

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord