Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Basic HTML CSS Flexbox

Gavin Loo• 100

@rawsashimi1604

Desktop design screenshot for the 3-column preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Practicing frontend design! Working on understanding more of flexbox

Community feedback

Juveria Dalvi• 1,375

@Juveria-Dalvi

Posted

Wrap div with class attribution in

<footer> <div class="attribution"> .... </div> </footer>

Marked as helpful

1

Vanza Setia• 27,795

@vanzasetia

Posted

@juuveria You can just swap the div with footer tag 😉.

Marked as helpful

0
Gavin Loo• 100

@rawsashimi1604

Posted

@vanzasetia Ok thank you guys!

0
Vanza Setia• 27,795

@vanzasetia

Posted

👋Hi Gavin Loo!

I have some feedback on this solution:

  • Don't use design image size as your breakpoint for @media query. You should make sure that your website looks great on any screen size.
  • For any decorative image, you should leave the alt="" and add aria-hidden="true" or role="presentation" to make sure all screen readers ignore those images. In this case, all the car icons are decorative images.
  • Only use one h1 for every page. I recommend to change all h1 to h2.
  • The Learn More button should be a anchor tag, not button. In real website, it will navigate the user to certain page.
  • Use box-sizing: border-box for every element, to prevent unexpected behavior. Always add this CSS on every project that you create.
* {
  box-sizing: border-box;
}

That's it! Hopefully this is helpful!

Marked as helpful

0

Gavin Loo• 100

@rawsashimi1604

Posted

@vanzasetia Hey Vanza, thank you for your advice!

0
P
hardy• 3,660

@hardy333

Posted

Hey, website looks super good on desktop but one issue is that it is not mobile responsive.

  • Try to always write mobile responsive css.
  • I suggest to watch this video to start learning how to use media queries.
3

Gavin Loo• 100

@rawsashimi1604

Posted

@hardy333 Okay, thank for your advice!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord