@AdrianoEscarabote
Posted
Hi Samuel, how are you?
Welcome to the front-end mentor community.
I really liked the result of your challenge, but I have some tips that I think you will like:
1- Document should have one main landmark, you could have put all the content inside the main
tag click here
I noticed that there is a scrollbar on the page, and the content is not centered, we can arrange both things like this:
I removed this one:
.container { /* margin: 20vh auto; */ }
I added these:
body { display: flex; align-items: center; justify-content: center; min height: 100vh; flex-direction: column; }
This will make the content centered on any resolution.
- { margin: 0; padding: 0; box-sizing: border-box; }
This will remove the scrollbar, adding margin and padding 0 to all elements on the page.
Hope it helps... ๐
The rest is great!!
Marked as helpful
@frasconi00
Posted
@AdrianoEscarabote Thanks a lot for the feedback and advice, especially for the scrollbar removing tips! Will implement this for sure in my future projects ๐