Basic HTML and CSS , nothing more.

Community feedback

• 

  mohammed bentalb•300

  @MohammedBentalbPosted about 1 year ago

  Hello Elliot, hope you're doing well, as this project isn't that much to show your weaknesses, It's obvious that only the shape matches the design. I'm just an intermediate dev, yet I would encourage you to stick as much as you can to the design and look up for things that u couldn't do/handle (some good ones for CSS and HTML u can look for Kevin Powell, web dev simplified and developedbyed) (those have some friendly beginning videos)

  1. use section instead of the first div since it has better semantic meaning and because the QR card is the only element there.
  2. not quite sure what do u mean but u can look up aspect-ratio in CSS for images, and try to not define its width in CSS unless u have to and let it depend on the width of the outer container while having a padding in the inside.
  3. try not to lock yourself in tutorial hell and build projects as you are learning not until u think u have learned everything

  (take this only as reference (maybe what I said wouldn't match your way of building things or maybe not perfect enough) as even I need to keep learning then ) have a good one

  Marked as helpful

  0