Basic HTML and CSS for the Profile Card

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey, Olmo! 👋

  Just wanted to say congratulations on completing your first Frontend Mentor challenge! 🎉 Good job on this one! 👍

  Your solution looks good and that animation of the profile picture is a cool touch! 😎

  Keep coding (and happy coding, too)! 😁

  1
• 

  Web Frog•1,840

  @MasterDev333Posted almost 4 years ago

  Great work @Olmo. I love your hover animation on avatar. As @axevldk said, it would be better if you use background-image property rather than using img tags. And from later solutions, try to make everything close to design. In the real world, we should make everything pixel perfect and fully responsive. Hope it helps. Happy coding~ :)

  1
• 

  Aleksandr Aksenov•750

  @axevldkPosted almost 4 years ago

  Hi, Olmo ~

  I have studied your work. Good work for you first challenge. Here are couple of my opinions to improve your work.

  1. You used image tags for background circle images, but I think using background-image css property or pseudo elements would be better in this case.

  2. Same with the top bar image for card.

  3. And you can organize elements of card in orderly. I am attaching my solution and github code here, so that you can reference, thought it's not a perfect solution.

  https://profile-card-component-orcin.vercel.app/

  https://github.com/axevldk/Profile-Card-Component.git

  Hope my opinion can help you even a bit. Happy coding, and keep coding ~

  1

  ---

  

  Olmo•30

  @olmoceriottiPosted almost 4 years ago

  Thank you for your feedback! I'll study your solution :)

  0