Basic HTML & CSS

Community feedback

• 

  Adriano•38,080

  @AdrianoEscarabotePosted about 2 years ago

  Hi wander, how are you?

  Welcome to the front-end mentor community!

  I really liked the result of your project, but I have some tips that I think you will enjoy:

  • every Html document must contain the main tag, so we can identify the main content, to fix this, wrap all the content with the main tag. HTML5 landmark elements are used to improve navigation experience on your site for users of assistive technology.
  • Consider using rem for font size .If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.

  The rest is great!

  I hope it helps... 👍

  Marked as helpful

  0

  ---

  

  wander•20

  @wanderstweekPosted about 2 years ago

  @AdrianoEscarabote thanks for the feedback! I will fix my code with HTML5 landmark element. I appreciate your suggestion. Best luck!

  0
• 

  N Conradie•50

  @Rexwins05Posted about 2 years ago

  Hello there, I would suggest to just take the <h3> font size to 20px and the <p> font size to 10px, the image size and the padding seems to be the right size, the margin on the top might be 5 or 10px too much maybe?

  But I must say, the break between the two lines in the heading, genius. I did not think of that one on my solution haha.

  If you make changes to the code, I found that it takes a minute or so for the code to reflect on the github pages after you made the commit. and you have 5 chances to generate a new screenshot under your solutions and then once the code has reflected then you can hit the generate new screenshot and then see the improvement.

  I hope this helps a little to get you closer to the example!

  Best of luck.

  Marked as helpful

  0

  ---

  

  wander•20

  @wanderstweekPosted about 2 years ago

  @Rexwins05 yeah, I dont know why my screenshot is so messed up. Everything looks good on my Github acc. I tried to generate new SH with 10 hours difference, but it's still the same. Nevermind... I know its' good :) Thanks for the feedback, I appreciate it!

  Best of luck!

  0
• 

  Ahmed•400

  @AhmedLebdaPosted about 2 years ago

  Hi @wanderstweek great start, congrats on completing the challenge

  To get the heading like the preview you just need some simple modifications to your code:

  1. you don't need to break the line with <br> tag the text will automatically wrap when the heading exceeds it's container width.
  2. you don't need the margin:15px on the h3 it adds unnecessary 15px on left and write of the heading
  3. you will just need to decrease the h3 to font-size:1.2rem.

  Now you have the heading just like the preview

  • Last tip you need to add a space after (front-end) in the heading 😉

  Good job , and Happy Coding

  Marked as helpful

  0

  ---

  

  wander•20

  @wanderstweekPosted about 2 years ago

  @AhmedLebda thanks! I'll try decreasing font-size. Also I will look at these margins that you mentioned! Thank you!

  Best of luck!

  0