Basic HTML and CSS

Community feedback

• 

  Finney•3,030

  @Finney06Posted over 1 year ago

  Hello there 👋. Good job on completing the challenge !

  Here are some suggestions regarding your code that may be of interest to you.

  HTML 🏷️:

  To clear the Accessibility report:

  • Wrap the page's whole main content in the <main> tag.

  • Starting with <h1> and working your way down the heading levels (<h2>, <h3>, etc.) helps ensure that your document has a clear and consistent hierarchy.

  • Use HTML5 semantic elements such as <header>, <nav>, <main>, <aside>, and <footer> to define these sections.

  • Use ARIA landmarks such as <header role="banner"> and <footer role="contentinfo"> to provide additional information about the purpose of each section to assistive technologies.

  Here is a web accessibility evaluation tool📕 to check your webpage for any remaining errors or warnings related to landmarks.

  I hope you find it helpful!😏 Above all, the solution you submitted is 👌. 🎉Happy coding!

  Marked as helpful

  0

  ---

  

  P

  Jacksen•350

  @jacksen30Posted over 1 year ago

  @Finney06 Thank you very much. This was very helpful.

  1
• 

  Francisco Carrillo•5,540

  @frank-itachiPosted over 1 year ago

  Hello there 👋. You did a good job!

  I have some suggestions about your code that might interest you.

  HTML 📄:

  • Wrap the page's whole main content in the <main> tag.
  • The heading order is important in the html structure so try to always start your headings and/or titles with an <h1> tag and then you can increase by one if you need to use more heading in your html code.

  CSS 🎨:

  • You can use grid or flexbox to center the content no matter the viewport size. Using Grid:

  body {
  	min-height: 100vh;
          display: grid;
  	place-content : center;
  }
  

  FlexBox

  body {
  	min-height: 100vh;
          display: flex;
  	align-items: center;
  	justify-content: center;
  }
  

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy <coding /> 😎!

  Marked as helpful

  0

  ---

  

  P

  Jacksen•350

  @jacksen30Posted over 1 year ago

  @frank-itachi Thanks so much for your feedback, all your advice is super helpful to me and will definitely be used in my future challenges and coding.

  Thanks for clearing up the heading tag confusion for me, My thinking was that this wouldn't typically be the <h1> on the page as there would be other elements but it makes much more sense to do as you say and just increment the existing headings if I was to add future headings above.

  0