Submitted over 3 years ago
Basic HTML and CSS and media queries for responsiveness
@karthik-gowda
Design comparison
SolutionDesign
Solution retrospective
Feedback's are much appreciated
Community feedback
- @waltersonoPosted over 3 years ago
Nice work Karthlk.
I looks As of a suggestion i would say:
-
Use "rem" instead of "pixels"
- Because "rem" unit is relative to the global font size, so that you can easily modify the size of the entire web elements on different view ports
-
Use a naming convention for your next projects
- You always want to write code that works and that is maintainable, code that others can understand and you can if you came back to see months later
- Try using BEM or other naming convention
-
Use "aria-label" for the input for accessibility
- When writing html code we should remember that there are people with some disabilities that will also use the site
- You can watch this video from google on accessibility: Web Accessibility
Marked as helpful1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord