basic html and css

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  Replace <div class="container"> with the main tag, <h3> with <h1> and <div class="content"> with <p> to fix the accessibility issue. click here for more on web-accessibility and semantic html

  Add the alt attribute alt=" " to the img tag and give it a value to fix the error issue. The value of the alt attribute is the description of the image. For decorative images like icons, there is no need to give it an alt value, for more on alt attribute Click here.

  There is no need to style .container .

  To center .card on the page using flexbox or grid instead of a margin, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

  USING FLEXBOX:
  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  USING GRID:
  body{
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  There is no need to give .card a height value. For a responsive content, replace the width in .card with max-width and increase its value. Give the img a max-width of 100% for a responsive image instead of a width.

  Give .textContainer a margin value for all the sides, text-align: center and a font-size of 15px which is 0.9375rem, this will be the font-size of both p and h1. Give p a margin-top or h1 a margin-bottom value for the space between the text.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  1
• 

  Nadir Bousalah•820

  @Medido1Posted over 1 year ago

  Great work !! Try to add the following code to center your card horizontally:

  body { min-height: 100vh; display: flex; flex-direction: column; justify-content: center; }

  Marked as helpful

  1