Basic HTML and CSS

Community feedback

• 

  Ahmed Bayoumi•6,740

  @Bayoumi-devPosted over 2 years ago

  Hey John, Great work! you just need to put the component in <main>...</main> tage

  Marked as helpful

  1

  ---

  

  John•20

  @JohnPORPosted over 2 years ago

  @Bayoumi-dev Hello

  Thanks for your feedback. I can't believe I forgot the main tags. I'm definitley going to kick myself over that one.

  0
• 

  Ryan•290

  @RJC26Posted over 2 years ago

  Hey man, looks great! I noticed you put margin: 0; padding:0; in body and box-sizing: border-box; in html, you could always use:

  *{
  box-sizing: border-box;
  margin: 0;
  padding: 0;
  }
  

  This does the same thing just a bit of tidying! Looks awesome!

  Marked as helpful

  0

  ---

  

  John•20

  @JohnPORPosted over 2 years ago

  @RJC26 Hello

  Thanks for the feedback.

  I've been watching loads of Brad Traversy's video and the does the same. Silly of me to miss considering how often I've seen it.

  0