Design comparison
Solution retrospective
Mostly happy with this. My one question would be have I overused the flex properties? I feel like I may have added them in places they aren't needed.
Community feedback
- @Mahesh-yadavPosted over 4 years ago
Normally, when container items automatically align as per source order, I do not use flex container. In your case:
body
element does not need to be a flex container. the.container
and.attribution
elements will by default align vertically. You can center them either throughmargin: auto
ortext-align: center
.- Similarly 'options-panel' does not need to be a flex container. Instead of using
justify-content: space-evenly
, I prefer to use margin properties .
Another comment: You defined
.speech-bubble:after
styles at two places: one each for desktop and moblie. Many of the properties are repeated with same values. When creating mobile design, we can define only those properties whose value needs to be overridden or are new properties. No need to repeat styles that are common to different layoutsYour speech bubble is not aligned with progress bar. Right side of both should be aligned vertically. You need to change
right
property for speech bubble1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord