Basic Html and Css

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  Replace<div class="container">with the main tag and <div class="attribution"> with the footer tag to make the page accessible. click here for more on web-accessibility and semantic html

  To make the image visible, remove ./images/ in the src value because is the image which is in the Github repositiry on the images folder. <img src="image-qr-code.png"> instead of <img src="./images/image-qr-code.png">.

  The body has a wrong background-color. give it a background-color of light-gray. Use the colors that were given in the styleguide.md found in the zip folder you downloaded.

  To center .container on the page using flexbox or grid, add min-height:100vh; display: flex; align-items: center: justify-content: center; to the body OR add min-height:100vh; display: grid place-items: center to the body

  • USING FLEXBOX:

  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  • USING GRID:

  body{
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  For a responsive content,

  • Replace the width in .container with a fixed max-width value and the height with a padding value for all the sides max-width: 320px which is 20rem/em padding:16px which is 1rem/em
  • Give the img a max-width of 100% and a border-radius value, the rest are not needed.

  There is no need to give .container a margin value.

  Give .text a margin value for all the sides and text-align: center. Give p a margin-top or h1 a margin-bottom value for the space between the text.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here and here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0
• 

  munibofficial•180

  @munibofficialPosted over 1 year ago

  Thanks hassia for your valueable feedback

  0