Basic HTML and CSS

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <div class="attribution"> element with the proper semantic element <footer> in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0
• 

  Ambadi M P•380

  @SoaphubPosted over 1 year ago

  Hello jtatan, great work. I would love to provide a suggestion on Google fonts. Reviewed your code in index.html. Found u have copied the link from google fonts with only a font weight of 800.

  • You can select different font-weight such as 300, 600 and 900 from the google fonts webpage. Then copy the link finally so that all font-weight is included in the same link.
  • In the style sheet, you could add the same font weights for the heading tag and para tag. Use font weight 900 for bolder text, 600 for medium text and 300 for regular text. In your code, you could use 900 or 600 for h1 tag and 300 for p tag.

  Marked as helpful

  0