Design comparison
Solution retrospective
Is my HTML structured well for a project like this? Was I too vague or too general in my styling rules (like styling <p>'s in general rather than making classes, for example)? Did I make any strange choices, such as using flexbox despite the fact that there is very little in the way of responsiveness? Is there anything that I could have done more efficiently (either in the sense of more compact code or the sense of computational/network efficiency)?
Community feedback
- @amulyalovescodingPosted about 2 years ago
Hello @pneumatick, Congratulations on completing this challenge! I really liked the result of your project, but I have some tips that I like to share:
1- Every page should have one main landmark <main>. So replace the div that wraps the whole content with <main> to improve the accessibility. click here
2- All page content should be contained by landmarks, you can understand better by clicking here: click here
Ans to your question - Your design is lacking mobile adaptability. You can use flexbox or grid or both in design. Both works well, both are responsive but both have slightly different functionality. Flex cannot overlap but grid can.
You can go through my solution if you like - Link
In the end, all that matters is design should be clean & should works.
✌️ I hope this helps you.
Marked as helpful0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord