Basic HTML and CSS

Community feedback

• 

  Hunter McGrew•150

  @HunterMcGrewPosted about 2 years ago

  By background image you mean "lighter.png" which looks like it was the favicon? it's a 32 by 32 pixel logo for the site. It's meant to be the logo that displays in the tab before the sites title. Since you took the favicon away, it's just a grey circle thing now. It looks like you stretched it from 32 by 32 to 500 by 350 and used it as the background for a div.

  Due to the fact that it's transparent and stretched so far beyond it's resolution, that's just what it's going to look like. It's doing what you told it to do.

  Marked as helpful

  1
• 

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  Hi James, congratulations on completing the challenge, great job! 😁

  Some little tips for optimizing your code:

  • add main tag and wrap the card for improve the Accessibility
  • also you can use article tag instead of a simple div to the container card for improve the Accessibility
  • remove all margin from #container id
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px use relative units of measurement like rem -> read here

  Hope this help! Happy coding 😉

  Marked as helpful

  0

  ---

  

  James Clinton•20

  @JamesBobby133Posted about 2 years ago

  @denielden Thanks alot.... This was really helpful. I was ill that's why i didn't respond earlier. But i'm well now. I would really be glad if you could me my mentor.

  0

  

  James Clinton•20

  @JamesBobby133Posted about 2 years ago

  @denielden Thanks alot.... This was really helpful. I was ill that's why i didn't respond earlier. But i'm well now. I would really be glad if you could me my mentor.

  0

  

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  @JamesBobby133 don't worry it was a pleasure! I will be happy to mentor you :)

  Keep it up !

  0

  

  James Clinton•20

  @JamesBobby133Posted about 2 years ago

  @denielden thanks a lot. I'd really appreciate that [email protected] is my email. Could I have yours so I could reach out to you. Or more so, how can I reach out to you?

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  @JamesBobby133 you can go into my website (link in my profile page) and contact me with the contact form :)

  0

  

  James Clinton•20

  @JamesBobby133Posted about 2 years ago

  @denielden thanks a lot. I'd do that. Thanks once again.

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  @JamesBobby133 it's a pleasure :)

  Marked as helpful

  0