Basic flexbox for alignment

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  • Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute. The alt attribute should explain its purpose. e.g. QR code to frontendmentor.io

  • Use min-height: 100vh instead of height: 100vh. The height property can cause your component to be cut off on small screens, such as a mobile phone in landscape mode.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  2

  ---

  

  Richard•140

  @RixCraftsPosted almost 2 years ago

  @MelvinAguilar

  Thank you very much for the feedback, I already implemented both suggestions, and take note in order to don't miss it in future projects..

  I usually make a description of the image in the 'alt' attribute but now I see that an explanation of the usage is much better and make more sense.

  0