Melvin Aguilar 🧑🏻💻• 61,220
@MelvinAguilar
Posted
Hello there 👋. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
- Since this component involves scanning the QR code, the image is not a decoration, so it must have an
altattribute. Thealtattribute should explain its purpose. e.g.QR code to frontendmentor.io
- Use
min-height: 100vhinstead ofheight: 100vh. Theheightproperty can cause your component to be cut off on small screens, such as a mobile phone in landscape mode.
I hope you find it useful! 😄 Above all, the solution you submitted is great!
Happy coding!
Marked as helpful
2
Richard• 140
@RixCrafts
Posted
@MelvinAguilar
Thank you very much for the feedback, I already implemented both suggestions, and take note in order to don't miss it in future projects..
I usually make a description of the image in the 'alt' attribute but now I see that an explanation of the usage is much better and make more sense.
0
