Submitted 7 months ago

Basic CSS

Michael Degorre• 110

@MDEGORRE

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

QR code component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

Basic challenge so nothing to be proud of

What challenges did you encounter, and how did you overcome them?

No difficulties

What specific areas of your project would you like help with?

Nothing but advices / best practices are still welcomed. 👍

Community feedback

Grace• 29,290

@grace-snow

Posted 7 months ago

Some feedback

Fix the code link above
Only import the specific font weights you need.
Think about the context of where this component would be used on a site. It would be inside the main landmark, it wouldn't be the main landmark.
this also needsa footer landmark for the attribution.
Make the img alt more descriptive by including the destination the QR code goes to.
It would be better for performance to include the reset at the start of your styles instead of making the browser go fetch another file.
Make sure you understand the difference between padding and margin

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord