Basic CSS - My First Submission 😅

Community feedback

• 

  Basit Korai•350

  @basitkoraiPosted over 1 year ago

  Hi, my friend. 👋 I'm so happy that you have completed the project

  I have some suggestions to make it better.

  • Instead of height: 100% go for min-height: 100vh; in the .container element for centering elements. Why don't you try this for centering everything instead flex.

  display: grid;
  place-items: center;
  min-height: 100vh;
  

  • Remove height from other elements instead use padding to scale them vertically. Try using this logical property, padding-block.
  • You should opt for the <article> tag for your component instead of cramming everything in the <main> tag. (for making it accessible for the screen readers)
  • Give your main image an alt="describe the image". (for better accessibility)
  • Decrease the padding around your image, to match the design further.
  • Instead of this <p>Improve your front...</p> go for <h1> tag. (every webpage must have at least one)
  • For the font-size, opt for the rem units instead of pixels. video resource

  Upvote the comment if it helps

  I hope these tips will help you improve your code.😊

  Happy Coding✌️

  Marked as helpful

  2