Basic css

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  Replace<div class="container">with the main tag, <h2> with <h1> and <div class="attribution"> with the footer tag to make the page accessible. click here for more on web-accessibility and semantic html

  Every html must have <h1> to make it accessible. Always begin the heading of the html with <h1> tag wrap the sub-heading of <h1> in <h2> tag, wrap the sub-heading of <h2> in <h3> this continues until <h6>, never skip a level of a heading.

  To center .container on the page using flexbox or grid instead of margin,

  • USING FLEXBOX: add min-height:100vh; display: flex; align-items: center: justify-content: center; to the body

  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  • USING GRID: add min-height:100vh; display: grid place-items: center to the body

  body{
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  For a responsive content which wont require a media query for this challenge,

  • Give .container a fixed max-width value and a padding value for all the sides max-width: 320px which is 20rem/em padding:16px which is 1rem/em
  • Give the img a max-width of 100% and a border-radius value, the rest are not needed.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  1

  ---

  

  slr8•100

  @slr8Posted over 1 year ago

  @Hassiai Got it , Thanks!

  0
• 

  Shaheed Wajee•220

  @wajeeNPCPosted over 1 year ago

  Well done doing your first HTML & CSS challenge, You have done so much better but there's a small problem in centering your container so I would recommend you to use min-height:100vh in your container so that it would be in the center of your screen ,Thats it other than that you did a great job and I hope you do more😊😊🤗.

  Marked as helpful

  1

  ---

  

  slr8•100

  @slr8Posted over 1 year ago

  @wajeeNPC thanks man!

  0