Skip to content
Submitted about 3 years ago

Base-Apperal

Carl Pericles•400
@CarlPericles18
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Base Apparel coming soon page
  • HTML
  • CSS
  • JS
1newbie

Design comparison

SolutionDesign

Solution retrospective

This is my first JS project worked on, any feedback would help. Thank you.

Community feedback

  • Dmitry•375
    @dmitrymitenkoffPosted about 3 years ago

    Great job on completing the challenge, Carl.

    Your JavaScript logic seems to be working as expected - well done.

    I see you used two divs with two feature photos in the HTML file. I think you could improve your HTML by using the <picture> HTML element to make it more responsive. You can read more about this element here.

    I also notice the <input> element doesn't have an accompanying <label> element, which is required for those users who use screen readers, for instance. If you want / need to hide the label (eg due to your design constraints), you can visually hide it but make it still available for the assistive technologies. Here's more info about this.

    Hope it helps! Cheers

    Marked as helpful
    0
    Carl Pericles•400
    @CarlPericles18Posted about 3 years ago

    @dmitrymitenkoff Will do, I appreciated

    0
    Dmitry•375
    @dmitrymitenkoffPosted about 3 years ago

    @CarlPericles18, no worries!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord