Vanza Setia• 27,795
@vanzasetia
Posted
Hi, ANSHUL LAMBA! 👋
A few suggestions for improvements:
- Use CSS to uppercase the text: Screen readers might spell the uppercased word in the HTML (spelled letter by letter).
- Readable alternative text: Alternative text should not be hyphenated.
- Meaningful alternative text: Alternative text for the logo should not be "logo". It should be the text of the logo—"Base Apparel".
- Decorative images should not have alternative text: Not every image needs alternative text. This will tell the screen reader to skip over the decorative images. As a result, it saves screen reader users time navigating the page. For your information, decorative images are images that do not add any information and serve only aesthetic purposes.
- Do not use
<br>
elements for presentation purposes: Remove the<br>
element inside the<h1>
. Screen readers may announce them as "break" which creates unnecessary noises. - Appropriate element: Use a paragraph element for the error message. Do not use
<h5>
. Also, wrap the input and the submit button with a<form>
element. - CSS reset: Use a CSS reset whenever you start a new project. This can help you set the styling foundation easily. My recommendation — A Modern CSS Reset | Andy Bell
- Do not use pixel unit for font sizes: Use
rem
orem
instead ofpx
for font sizes. Never usepx
unit. Relative units such asrem
andem
can adapt when the users change the browser's font size setting. Learn more — Why you should never use px to set font-size in CSS
I hope this helps. Happy coding! 🙂
Marked as helpful
0
ANSHUL LAMBA• 120
@Hawk3037
Posted
thank you, buddy I will be taking care of all my mistakes on my upcoming challenges @vanzasetia
0
Vanza Setia• 27,795
@vanzasetia
Posted
@Hawk3037 Good!
1