Base-Apparel-coming-soon-page

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted over 3 years ago

  Hey Nazir, congrats on submitting another solution. This is a deceptively tricky challenge!

  Here are some pointers after taking a look at your code:

  • You're not using any headings at the moment. Headings are critical in HTML to provide a hierarchy for the content. The "We're coming soon" text would be a perfect candidate to be a h1 element.
  • You've wrapped your content in a container and set a width on it. As you can see from the design comparison, the content doesn't have a container.
  • For the "We're coming soon" text, you've uppercased the content in the HTML itself. Try to avoid doing that as some screen reader software will read this content letter-by-letter, making that content inaccessible. Instead, write it normally in your HTML and then use text-transform: uppercase; in your CSS to visually uppercase the text to match the design. It would be a good exercise for you to go through the report and try to resolve the listed issues. Once you've updated your code, you can click the "Generate new report" button at the top of the report page to see if you've resolved the issues.

  I've taken a quick look at your profile page. I'd recommend taking some time to go back through the projects you've already submitted to try getting them closer to the designs. Attention to detail is a key trait in a front-end developer, so it's well worth spending the time to try refining your projects.

  I hope these tips are helpful. Let me know if you've got any questions. Keep it up! 👍

  Marked as helpful

  0
• 

  Nazir Abubakar•270

  @naziiriahPosted over 3 years ago

  Thanks for taking your time to give me a response. I always thought the use of header tags was for a complete website. I appreciate the tips.

  0