base-apparel-coming-soon-page

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  COMPONENT MEASUREMENTS 📐:

  • The measurements is applied for mobile devices, actually there's a serious issue with this

  .content[_ngcontent-xjt-c8] {
  width: 100vw;
  height: 100vh;
  overflow: hidden;
  }
  

  ---

  • The width: 100% property for div element is not necessary. because it's a block level element which will take the full width of the page by default.

  ---

  • Use min-height: 100vh for div instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.

  ---

  • For example; if we set height: 100vh then the div will have 100vh height no matter what. Even if the content spans more than 100vh of viewport.

  ---

  • But if we set min-height: 100vh then the div will start at 100vh, if the content pushes the div beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0
• 

  _nehal💎•6,710

  @NehalSahu8055Posted over 1 year ago

  Hello Coder 👋.

  Congratulations on successfully completing the challenge! 🎉

  Few suggestions regarding design.

  • Remove commented line below and see the effect.

  .content[_ngcontent-xiq-c8] {
  /*width: 100vw;*/ Makes no sense to use, it only make us to scroll across horizontally.
  /* overflow: hidden; */  Makes no sense to use, it make us unable to scroll vertically.
  }
  

  I hope you find this helpful.

  Happy coding😄

  0