Base-apparel-coming-soon-page - HTML CSS JavaScript

Community feedback

• 

  Pradeep Saini•990

  @pradeeps4iniPosted over 2 years ago

  Hi, Adam.

  Your project looks great.

  I would like to suggest few changes, which will make your code a little better.

  • In the desktop mode, .hero-img has "height: 100vh", when we minimize the window height, it makes the image to become shorter and also the top of image goes out of focus. You should change it to "height: auto", this way image will take the space it needs and also stay in focus and won't lose its height.

  • Don't use <header> element twice on the page. Use it only once to define the header of the page. You're using header to wrap the image, which is not good for accessibility.

  Marked as helpful

  0

  ---

  

  Adam Baker•90

  @ABaker14791Posted over 2 years ago

  @pradeeps4ini Thanks I'll look into chose suggestions

  0