base-apparel-coming-soon-master-page using flexbox and sass

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 2 years ago

  Hello there, JoannaKalbarczyk! 👋

  Well done on this challenge! 👍 Your solution looks good! 🙌

  Here are a couple of things I'd like to suggest,

  • Adding object-fit: cover to the hero image on the page so that the image does not seem stretched or squeezed when its aspect ratio/dimensions change.
  • Adding some more descriptive alt text to the images in the page. That’s because alt text is read by screen readers to describe images to users, so it’s important to write alt text that makes sense and will give users a good sense of the content and purpose of an image.

  A simple way to make your site more responsive is to simply switch to a mobile-friendly layout sooner. That way, you can prevent the content of the page from looking very squeezed right before the layout changes. Here's a pretty good solution to this challenge that you can check out if you'd like some ideas.

  If you’d like to learn more about how to make sites responsive, check out this helpful course.

  Hope this helps. 😊

  Keep coding (and happy coding, too)! 😁

  Marked as helpful

  2
• 

  Rajat Bhatt•280

  @bhattrajatPosted over 2 years ago

  Hi @JoannaKalbarczyk, congratulations on finishing the challenge. I suggest you make it the tablet view same as the mobile view that way It will adjust the content/text in a better way for the tablet view.

  0