Base-apparel-coming-soon-master

Community feedback

• 

  P

  visualdennis•8,375

  @visualdennissPosted over 1 year ago

  Hey there,

  Good work in completing the challenge!

  It looks like your app does not cover the entire screen, on larger screen-sizes there are some empty spaces around the grid. It is normal to have a max-width for the entire app, but having empty space on the top is not recommended as it is now. So you can try to cover the entire screen, starting with width: 100% for you grid and making further height and layout adjustments as needed.

  Hope you find this feedback helpful!

  Marked as helpful

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  JAVASCRIPT 💢:

  • The way you declared variables are need to be well structured and organized

  ---

  • Take a look at the following example code which describes an efficient way of declaring variables

  const firstName = "Your";
  const lastName = "Name";
  const emailAddress = "[email protected]";
  const password = "supersecret";
  

  • instead try this,

  const firstName =  "Your",
         lastName =  "Name",
         emailAddress = "[email protected]"
         •••                
         •••         // n number of declarations
         password = "supersecret";   // make sure to add a semicolon at end of last declaration
  

  • This single line declaration with separated commas will helps you to have a better structured code and improves readability though

  ---

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0