Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Base-Apparel-Coming-Soon-Component

rick881ā€¢ 230

@rick881

Desktop design screenshot for the Base Apparel coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


feel free to give feedback

Community feedback

@0xabdulkhaliq

Posted

Hello there šŸ‘‹. Congratulations on successfully completing the challenge! šŸŽ‰

  • I have other recommendations regarding your code that I believe will be of great interest to you.

HEADINGS āš ļø:

  • This solution has generated accessibility error report due to lack of level-one heading <h1>
  • Every site must want at least one h1 element identifying and describing the main content of the page.
  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

BUTTONS šŸ–²ļø:

  • This solution had generated accessibility error reports due to lack discernible text for <button> element
  • The <button> must have discernible text that clearly describes the destination, purpose, function, or action for screen reader users.
  • Screen reader users are not able to discern the purpose of elements with role="link", role="button", or role="menuitem" that do not have an accessible name.
  • The <button> name rule has five markup patterns that pass test criteria:

<button id="al" aria-label="Name"></button>

<button id="alb" aria-labelledby="labeldiv"></button>

<div id="labeldiv">Button label</div>

<button id="combo" aria-label="Aria Name">Name</button>

<button id="buttonTitle" title="Title"></button>

  • Ensure that each <button> element and elements with role="button" have one of the following characteristics:

    • Inner text that is discernible to screen reader users.
    • Non-empty aria-label attribute.
    • aria-labelledby pointing to element with text which is discernible to screen reader users.
    • role="presentation" or role="none" (ARIA 1.1) and is not in tab order (tabindex="-1")

.

I hope you find this helpful šŸ˜„ Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

0

@Daniel-Bilodid

Posted

Hi, my congratulations you did a great job šŸŽ‰

š’šØš¦šž š­š¢š©š¬ šŸšØš« š²šØš®š« šœšØššž šŸ› 

šŸ”¹ About width and height

for the container, you can set the width to 100vw and you can do the same with the height 100 vh

šŸ“š The unit vh corresponds to 1% of the height of the browser's viewport, so 100vh is equal to the entire height of the viewport. Elements whose height is set in vh units will change their size when the browser window is resized.

šŸ”¹ And you need to add an alt tag to your images

šŸ“š The alt attribute contains a textual description of the image, which is optional but incredibly useful for accessibility

I hope it was helpful, you are great, keep up the good work šŸ‘

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord