base-apparel-coming-soon with vanilla Js, and basic html-css

Community feedback

• 

  Boyan Liu•465

  @BoyanLiuuPosted almost 4 years ago

  Hello , Iqbal Everything looks good to me , but I would like to give some suggestion for the css part. I notice that you are using rem , which is nice. I am suggesting you can set font-size:62.5% in the root. It would turn default 16 px into 10 px which you could easily do the math in the future. Another one is You can add box-sizing: border-box; in the root element as well. It guarantees that the content box shrinks to make space for the padding and borders. Therefore, if you set your element width to 200 pixels, border-box makes sure that the content, padding, and borders fit in this number

  https://developer.mozilla.org/en-US/docs/Web/CSS/box-sizing

  Happy coding!

  2

  ---

  

  Iqbal•135

  @Firdausi-IqbalPosted almost 4 years ago

  @BoyanLiuu thanks Boyan, your suggestion is great. The problem is that your suggestion is on point. I was wandering lately what if i change the default to make it easier to do the math and here you come with your suggestion and how i can solve my problem. Thanks so much 😁

  0