Skip to content
Submitted about 2 years ago

Base-apparel

Tertsegha Kpughur-Tule Moses•210
@Mosestule2003
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Base Apparel coming soon page
  • HTML
  • CSS
  • JS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hey guys, I just finished a new project, Try checking it out. Please any feedback is appreciated. :)

Community feedback

  • Carlos E Alford•285
    @webshurikenPosted about 2 years ago

    Hi, Nice effort on the challenge! There are two things I wanted to feedback on:

    • A <button> and <a> should not be used together. They are similar but have different roles. Here is a little article about the differences: https://bitsofco.de/anchors-vs-buttons/
    • As the button doesn't have a descriptive text, think about using an aria-label so assistive technologies announce its purpose. (there are other ways to achieve this)

    Hope it helps and keep going :)

    Regards, Carlos

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord