Design comparison
Solution retrospective
This one is was one of the best interesting challenge that i completed with a lot of helpful resources. Any feedback to take this to the next level is highly appreciated. Thanks in advance.
Community feedback
- @A-amonPosted over 3 years ago
Hello! Great job~
I have a few suggestions for you (that could level it up! 😀)
-
Put the main content of your site inside main tag. (Then, regenerate the report)
-
Put input element, .error and #errorImg inside a div. This way, when you absolute position your #errorImg, it will be relative to the div instead of the form. (So that you don't have to manually set the value for #errorImg's left to 17rem. Instead, you just need to set right:0)
-
The alt describes the image but in the case of your submit button, it describes the action. E.g. Send email/ Submit.
-
Instead of setting the style directly in JS to show/hide something, add/remove or toggle class instead. E.g. adding .error class to show error-related styles.
I learnt about validity.valid, thanks to you! 😀
Marked as helpful1@Skyz03Posted over 3 years ago@A-amon Thanks for the valuable feedback will surely implement this out.
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord