Base apparel with Grid positioning for desktop

Community feedback

• 

  P

  Nitya Gulati•665

  @nityagulatiPosted over 4 years ago

  Looks good, Sol! Your code is clean and well structured. Great work coding mobile-first and using Grid.

  • You don't need to add the space character inside the hero div. You can just have an empty div in the html and it will still take the background image and height/width settings from your css.

  • Currently, if the email field is empty, it displays the error for a few seconds and then submits the form. You will need to prevent the form from submitting when the email does not validate in your js code.

  • Mobile breakpoints 375px and below show a horizontal scrollbar, you probably need to adjust the margins slightly. You can test it out using Chrome Developer tools.

  Keep up the good work!

  1
• 

  Eliazar Lopez•25

  @eliazarndPosted over 4 years ago

  Hello, i like how you used grid for creating a layaout

  I saw your structure and code of css, i found out your issue, your image can not get full size, because you need to give a height to your container because thats the main feature of landing page.

  Your image needs a property like background-size: cover, with this property you cover all the container of your image.

  Thats it,

  Gretting and continue relearning all wonderful things of this world.

  1
• 

  Sol B W•80

  @solybarrPosted over 4 years ago

  Thank you @nityagulati !

  0
• 

  Sol B W•80

  @solybarrPosted over 4 years ago

  Thank you @eliazarnd!

  0