@nityagulati
Posted
Looks good, Sol! Your code is clean and well structured. Great work coding mobile-first and using Grid.
-
You don't need to add the space character inside the
hero
div. You can just have an emptydiv
in the html and it will still take the background image and height/width settings from your css. -
Currently, if the email field is empty, it displays the error for a few seconds and then submits the form. You will need to prevent the form from submitting when the email does not validate in your js code.
-
Mobile breakpoints 375px and below show a horizontal scrollbar, you probably need to adjust the margins slightly. You can test it out using Chrome Developer tools.
Keep up the good work!